lindeas
/
jilo-web
1
1
Fork 0
Code Issues Pull Requests Packages Projects Releases 4 Wiki Activity

Adds check if config file is writable

main
Yasen Pramatarov 2024-11-06 18:39:51 +02:00
parent c40dc747d3
commit c245bbb3be
1 changed files with 9 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
app/pages/config.php
View File

@ -17,12 +17,17 @@ if ($_SERVER['REQUEST_METHOD'] == 'POST') {
// editing the config file // editing the config file
if (isset($_POST['item']) && $_POST['item'] === 'config_file') { if (isset($_POST['item']) && $_POST['item'] === 'config_file') {
// check if file is writable
if (!is_writable($config_file)) {
$_SESSION['error'] = "Configuration file is not writable.";
} else {
$result = $configObject->editConfigFile($_POST, $config_file); $result = $configObject->editConfigFile($_POST, $config_file);
if ($result === true) { if ($result === true) {
$_SESSION['notice'] = "The config file is edited."; $_SESSION['notice'] = "The config file is edited.";
} else { } else {
$_SESSION['error'] = "Editing the config file failed. Error: $result"; $_SESSION['error'] = "Editing the config file failed. Error: $result";
} }
}
// new host adding // new host adding
} elseif (isset($_POST['new']) && isset($_POST['item']) && $_POST['new'] === 'true' && $_POST['item'] === 'host') { } elseif (isset($_POST['new']) && isset($_POST['item']) && $_POST['new'] === 'true' && $_POST['item'] === 'host') {
@ -144,14 +149,6 @@ if ($_SERVER['REQUEST_METHOD'] == 'POST') {
} }
// FIXME - if this is not needed for editing the flat file, remove it
// // check if file is writable
// if (!is_writable($config_file)) {
// $_SESSION['error'] = getError('Configuration file is not writable.');
// header("Location: $app_root?platform=$platform_id&page=config");
// exit();
// }
// FIXME the new file is not loaded on first page load // FIXME the new file is not loaded on first page load
unset($config); unset($config);
header("Location: $app_root?page=config&item=$item"); header("Location: $app_root?page=config&item=$item");