lindeas
/
jilo-web
1
1
Fork 0
Code Issues Pull Requests Packages Projects Releases 6 Wiki Activity

Fixes session tests error

main
Yasen Pramatarov 2025-09-29 21:35:57 +03:00
parent 29c2ecf40c
commit 77f5921dff
1 changed files with 24 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
app/classes/session.php
View File

@ -35,14 +35,17 @@ class Session {
// Get session name from config or generate a random one // Get session name from config or generate a random one
self::$sessionName = $config['session']['name'] ?? self::generateRandomSessionName(); self::$sessionName = $config['session']['name'] ?? self::generateRandomSessionName();
// Set session name before starting the session // Set session name before starting the session, only if headers not sent and no active session
if (session_status() === PHP_SESSION_NONE && !headers_sent()) {
session_name(self::$sessionName); session_name(self::$sessionName);
}
// Set session cookie parameters // Set session cookie parameters only if headers not sent and no active session
$thisPath = $config['folder'] ?? '/'; $thisPath = $config['folder'] ?? '/';
$thisDomain = $config['domain'] ?? ''; $thisDomain = $config['domain'] ?? '';
$isSecure = isset($_SERVER['HTTPS']); $isSecure = isset($_SERVER['HTTPS']);
if (session_status() === PHP_SESSION_NONE && !headers_sent()) {
session_set_cookie_params([ session_set_cookie_params([
'lifetime' => 0, // Session cookie (browser session) 'lifetime' => 0, // Session cookie (browser session)
'path' => $thisPath, 'path' => $thisPath,
@ -51,6 +54,11 @@ class Session {
'httponly' => true, 'httponly' => true,
'samesite' => 'Strict' 'samesite' => 'Strict'
]); ]);
}
// Align session start options dynamically with current transport
self::$sessionOptions['cookie_secure'] = $isSecure ? 1 : 0;
self::$sessionOptions['cookie_samesite'] = 'Strict';
self::$initialized = true; self::$initialized = true;
} }
@ -109,8 +117,11 @@ class Session {
* @return bool True if session is valid, false otherwise * @return bool True if session is valid, false otherwise
*/ */
public static function isValidSession($strict = true) { public static function isValidSession($strict = true) {
// If session is not started or empty, it's not valid // Ensure a session is started (safe in CLI/tests)
if (session_status() !== PHP_SESSION_ACTIVE || empty($_SESSION)) { self::startSession();
// If there is no session data at all, it's not valid
if (empty($_SESSION)) {
return false; return false;
} }