From eff4b073f5b6adabac9e73effe964e31f4cb931d Mon Sep 17 00:00:00 2001
From: Yasen Pramatarov <yasen@lindeas.com>
Date: Tue, 2 Jul 2024 20:04:12 +0300
Subject: [PATCH] Session cookie fixes

---
 jilo-web.conf.php           |  2 +-
 public_html/pages/login.php | 13 +++++++------
 2 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/jilo-web.conf.php b/jilo-web.conf.php
index 65d1fe9..8ba1187 100644
--- a/jilo-web.conf.php
+++ b/jilo-web.conf.php
@@ -1,7 +1,7 @@
 <?php
 
 $config = [
-    'domain'		=> 'localhost',
+    'domain'		=> 'localhost.com',
     'folder'		=> '/jilo-web/',
     'database'		=> '/home/yasen/work/code/git/lindeas-code/jilo-web/jilo-web.db',
 ];
diff --git a/public_html/pages/login.php b/public_html/pages/login.php
index a41d6be..b10af61 100644
--- a/public_html/pages/login.php
+++ b/public_html/pages/login.php
@@ -19,26 +19,27 @@ try {
             // if remember_me is checked, max out the session
             if (isset($_POST['remember_me'])) {
                 // 30*24*60*60 = 30 days
-                $cookie_lifetime = '30 * 24 * 60 * 60';
-                $gc_maxlifetime = '30 * 24 * 60 * 60';
+                $cookie_lifetime = 30 * 24 * 60 * 60;
+                $gc_maxlifetime = 30 * 24 * 60 * 60;
             } else {
                 // 0 - session end on browser close
                 // 1440 - 24 minutes (default)
-                $cookie_lifetime = '0';
-                $gc_maxlifetime = '1440';
+                $cookie_lifetime = 0;
+                $gc_maxlifetime = 1440;
             }
 
             // set session lifetime
-            ini_set('session.cookie_lifetime', $cookie_lifetime);
             ini_set('session.gc_maxlifetime', $gc_maxlifetime);
             session_set_cookie_params([
-                'lifetime' => $lifetime,
+                'lifetime' => $cookie_lifetime,
                 'samesite' => 'Strict',
                 'httponly' => true,
                 'secure' => isset($_SERVER['HTTPS']),
                 'domain' => $config['domain'],
                 'path' => $config['folder']
             ]);
+            session_start();
+
             // redirect to index
             $_SESSION['notice'] = "Login successful";
             header('Location: index.php');