From a953dd386d8edcaf7fbffbecfc54bb2e03948095 Mon Sep 17 00:00:00 2001
From: Yasen Pramatarov <yasen@lindeas.com>
Date: Tue, 29 Oct 2024 13:45:27 +0200
Subject: [PATCH] Fixes configfile edit form

---
 app/helpers/render.php                   | 16 +++-------------
 app/templates/config-configfile-edit.php |  2 +-
 2 files changed, 4 insertions(+), 14 deletions(-)

diff --git a/app/helpers/render.php b/app/helpers/render.php
index a14f81a..7e24034 100644
--- a/app/helpers/render.php
+++ b/app/helpers/render.php
@@ -47,30 +47,20 @@ function editConfig($configPart, $indent, $platform=false, $parent='') {
 <?php foreach ($configPart as $config_item => $config_value) { ?>
                             <div class="row mb-1" style="padding-left: <?= $indent ?>px;">
                                 <div class="col-md-4 text-end">
-                                    <?= htmlspecialchars($config_item) ?>:
                                     <label for="<?= htmlspecialchars($config_item) ?>" class="form-label"><?= htmlspecialchars($config_item) ?></label>
-                                    <span class="text-danger" style="margin-right: -12px;">*</span>
                                 </div>
 
 <?php
             if (is_array($config_value)) {
                 // here we render recursively nested arrays
                 $indent = $indent + 50;
-                if ($parent === 'platforms') {
-                    $indent = 100;
-                }
-                if ($config_item === 'platforms') {
-                    editConfig($config_value, $indent, $platform, 'platforms');
-                } else {
-                    editConfig($config_value, $indent, $platform);
-                }
+                editConfig($config_value, $indent, $platform);
                 $indent = 0;
             } else {
                 // if it's not array, just display it
 ?>
-                                <div class="border col-md-8 text-start">
-                                    <?= htmlspecialchars($config_value ?? '')?>
-                                    <input class="form-control" type="text" name="<?= htmlspecialchars($config_value) ?>" value="<?= htmlspecialchars($config_value ?? '') ?>" required autofocus />
+                                <div class="col-md-8 text-start">
+                                    <input class="form-control" type="text" name="<?= htmlspecialchars($config_item) ?>" value="<?= htmlspecialchars($config_value ?? '') ?>" required autofocus />
                                 </div>
 <?php       } ?>
                             </div>
diff --git a/app/templates/config-configfile-edit.php b/app/templates/config-configfile-edit.php
index ee41c32..cd2e44c 100644
--- a/app/templates/config-configfile-edit.php
+++ b/app/templates/config-configfile-edit.php
@@ -13,7 +13,7 @@ echo "\n";
 ?>
 
                             <br />
-                            <a class="btn btn-secondary" href="<?= htmlspecialchars($app_root) ?>?page=config#platform<?= htmlspecialchars($platform_id) ?>" />Cancel</a>
+                            <a class="btn btn-secondary" href="<?= htmlspecialchars($app_root) ?>?page=config&item=config_file" />Cancel</a>
                             <input type="submit" class="btn btn-primary" value="Save" />
                         </form>