From 619476e799e068e64db86c8dd2a7276d0a80c08b Mon Sep 17 00:00:00 2001
From: Yasen Pramatarov <yasen@lindeas.com>
Date: Thu, 13 Nov 2025 16:37:47 +0200
Subject: [PATCH] Fixes test DB migration functionality

---
 app/pages/admin-tools.php     | 61 +++++++++++++++++++++++++++++++++++
 app/templates/admin-tools.php | 16 +++++++++
 2 files changed, 77 insertions(+)

diff --git a/app/pages/admin-tools.php b/app/pages/admin-tools.php
index dc08610..cebac0b 100644
--- a/app/pages/admin-tools.php
+++ b/app/pages/admin-tools.php
@@ -97,11 +97,67 @@ if ($action !== '') {
             $migrationsDir = __DIR__ . '/../../doc/database/migrations';
             $runner = new \App\Core\MigrationRunner($db, $migrationsDir);
             $applied = $runner->applyPendingMigrations();
+            
+            // Clean up any test migration files after applying
+            if (!empty($applied)) {
+                foreach ($applied as $migration) {
+                    if (strpos($migration, '_test_migration.sql') !== false) {
+                        $filepath = $migrationsDir . '/' . $migration;
+                        if (file_exists($filepath)) {
+                            unlink($filepath);
+                        }
+                        // Remove from database migrations table to leave no trace
+                        $stmt = $db->getConnection()->prepare("DELETE FROM migrations WHERE migration = :migration");
+                        $stmt->execute([':migration' => $migration]);
+                    }
+                }
+            }
+
             if (empty($applied)) {
                 Feedback::flash('NOTICE', 'DEFAULT', 'No pending migrations.', true);
             } else {
                 Feedback::flash('NOTICE', 'DEFAULT', 'Applied migrations: ' . implode(', ', $applied), true);
             }
+        } elseif ($action === 'create_test_migration') {
+            $migrationsDir = __DIR__ . '/../../doc/database/migrations';
+            $timestamp = date('Ymd_His');
+            $filename = $timestamp . '_test_migration.sql';
+            $filepath = $migrationsDir . '/' . $filename;
+
+            // Create a simple test migration that adds a test setting (MariaDB compatible)
+            $testMigration = "-- Test migration for testing purposes\n";
+            $testMigration .= "-- This migration adds a test setting to settings table\n";
+            $testMigration .= "INSERT INTO settings (`key`, `value`, updated_at) VALUES ('test_migration_flag', '1', NOW())\n";
+            $testMigration .= "ON DUPLICATE KEY UPDATE `value` = '1', updated_at = NOW();\n";
+
+            if (file_put_contents($filepath, $testMigration)) {
+                Feedback::flash('NOTICE', 'DEFAULT', 'Test migration created: ' . $filename, true);
+            } else {
+                Feedback::flash('ERROR', 'DEFAULT', 'Failed to create test migration file', false);
+            }
+        } elseif ($action === 'clear_test_migrations') {
+            $migrationsDir = __DIR__ . '/../../doc/database/migrations';
+
+            // Find and remove test migration files
+            $testFiles = glob($migrationsDir . '/*_test_migration.sql');
+            $removedCount = 0;
+
+            foreach ($testFiles as $file) {
+                $filename = basename($file);
+                if (file_exists($file)) {
+                    unlink($file);
+                    $removedCount++;
+                }
+                // Remove from database migrations table to leave no trace
+                $stmt = $db->getConnection()->prepare("DELETE FROM migrations WHERE migration = :migration");
+                $stmt->execute([':migration' => $filename]);
+            }
+
+            if ($removedCount > 0) {
+                Feedback::flash('NOTICE', 'DEFAULT', 'Cleared ' . $removedCount . ' test migration(s)', true);
+            } else {
+                Feedback::flash('NOTICE', 'DEFAULT', 'No test migrations to clear', true);
+            }
         }
     } catch (Throwable $e) {
         Feedback::flash('ERROR', 'DEFAULT', 'Action failed: ' . $e->getMessage(), false);
@@ -121,10 +177,15 @@ $migrationsDir = __DIR__ . '/../../doc/database/migrations';
 $pending = [];
 $applied = [];
 $migration_contents = [];
+$test_migrations_exist = false;
 try {
     $runner = new \App\Core\MigrationRunner($db, $migrationsDir);
     $pending = $runner->listPendingMigrations();
     $applied = $runner->listAppliedMigrations();
+
+    // Check if any test migrations exist
+    $test_migrations_exist = !empty(glob($migrationsDir . '/*_test_migration.sql'));
+
     // Preload contents for billing-admin style modals
     $all = array_unique(array_merge($pending, $applied));
     foreach ($all as $fname) {
diff --git a/app/templates/admin-tools.php b/app/templates/admin-tools.php
index 676ce67..1ace70d 100644
--- a/app/templates/admin-tools.php
+++ b/app/templates/admin-tools.php
@@ -55,6 +55,22 @@
                     <?php if (!empty($migration_error)): ?>
                         <div class="alert alert-danger">Error: <?= htmlspecialchars($migration_error) ?></div>
                     <?php endif; ?>
+                    <div class="alert alert-info mb-3">
+                        <strong>Test Migration Tools</strong><br>
+                        <small class="text-muted">These tools create fake migrations in the database only (no files) for testing the migration warning functionality.</small>
+                    </div>
+                    <div class="d-flex gap-2 mb-3">
+                        <form method="post" class="d-inline">
+                            <input type="hidden" name="csrf_token" value="<?= htmlspecialchars($csrf_token) ?>">
+                            <input type="hidden" name="action" value="create_test_migration">
+                            <button type="submit" class="btn btn-outline-info btn-sm" <?= !empty($test_migrations_exist) ? 'disabled' : '' ?>>Create test migration</button>
+                        </form>
+                        <form method="post" class="d-inline">
+                            <input type="hidden" name="csrf_token" value="<?= htmlspecialchars($csrf_token) ?>">
+                            <input type="hidden" name="action" value="clear_test_migrations">
+                            <button type="submit" class="btn btn-outline-secondary btn-sm" <?= empty($test_migrations_exist) ? 'disabled' : '' ?>>Clear test migrations</button>
+                        </form>
+                    </div>
                     <div class="mb-3">
                         <div class="d-flex justify-content-between align-items-center">
                             <div><strong>Pending</strong></div>